[PHP 8.4] PCRE - PCRE2-v10.44 updates #4078
Open
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Nov 16, 2024
Comment on lines
+1578
to
+1591
| Prior to PHP 8.4.0, an opening curly bracket that | ||
| appears in a position where a quantifier is not allowed, or | ||
| one that does not match the syntax of a quantifier, is taken | ||
| as a literal character. For example, {,6} is not a quantifier, | ||
| but a literal string of four characters. | ||
| as a literal character. For example, <literal>{,6}</literal> | ||
| is not a quantifier, but a literal string of four characters. | ||
|
|
||
| As of PHP 8.4.0, the PCRE extension is bundled with PCRE2 version 10.44, | ||
| which allows patterns such as <literal>\d{,8}</literal> and they are | ||
| interpreted as <literal>\d{0,8}</literal>. | ||
|
|
||
| Further, as of PHP 8.4.0, space characters around quantifiers such as | ||
| <literal>\d{0 , 8}</literal> and <literal>\d{ 0 , 8 }</literal> are allowed. |
There was a problem hiding this comment.
Possibly those should be 3 different <simpara> ?
There was a problem hiding this comment.
Thank you, it makes sense that we split them.
<simpara> |
<para> |
|---|---|
 |
 |
I tried with three <simpara> tags, and a separate <para>, I liked the second one because it puts all PHP 8.4 stuff together, and looks more compact. What do you think? I pushed with the <para> tag now, but if you think <simpara> makes more sense, I can quickly change to that too 🙏.
There was a problem hiding this comment.
<simpara> is better than a <para> tag, it is just the grouping that matters here.
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/rmodifier.More changes noted here and here.
Unicode script list here was not updated for quite a while. As of PHP 8.4.0, there are close to 230 scripts and 160 shorthand script names. The table would need a bigger update, and not part of the PR, but will be added in a future PR.